A68 random subsetting (part 1) #12377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zgoda91
force-pushed
the
A68_random_subsetting
branch
from
9178308 to
aefee00
Compare
Zgoda91
force-pushed
the
A68_random_subsetting
branch
from
aefee00 to
1870e6f
Compare
ejona86
reviewed
Oct 2, 2025
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
This reverts commit 8d349df.
|
@ejona86 - PR updated |
ejona86
reviewed
Oct 6, 2025
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/test/java/io/grpc/util/RandomSubsettingLoadBalancerTest.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancerProvider.java
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
|
@ejona86 - PR updated. |
ejona86
reviewed
Oct 7, 2025
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancerProvider.java
Outdated
Show resolved
Hide resolved
.../proto/envoy/extensions/load_balancing_policies/random_subsetting/v3/random_subsetting.proto
Outdated
Show resolved
Hide resolved
|
@ejona86 - pushed changes. However, I do have two questions, which I have posted as answers to your comments. |
ejona86
reviewed
Oct 30, 2025
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancerProvider.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Internal | ||
| public final class RandomSubsettingLoadBalancerProvider extends LoadBalancerProvider { | ||
| private static final String POLICY_NAME = "random_subsetting"; |
There was a problem hiding this comment.
I need to ask around to remember if we decided it should initially be _experimental until a user says it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementing gRFC A65 grpc/proposal/pull/423
This change contains:
Relocation ofUsage ofXxHash64library, so it can be shared betweenutilandxdsprojects. Proposed source directory is:third-party/zero-allocation-hashing.murmur3_128hashing algorithm from Guava library.RandomSubsettingLoadBalancerandRandomSubsettingLoadBalancerProviderclasses and integration into theutilproject.Implementation of xDS conversion function forSince envoy extensions does not supportrandom_subsettingLB policy and as well new envoy proto message.random_subsettingLB policy yet, xDS related changes will be introduced later. Envoy PR here.